-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typing for python 3.9 #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you, @JustRedTTG !
I'd like @chrisdickinson to just do a quick pass before we merge, to be sure there aren't side effects here that I (a Python noob) am unaware of.
Hey still waiting, everything should be good, I only changed like two lines of code haha. Waiting on @chrisdickinson then. Just came in to bump this |
Aha, apologies! We only build the |
(I've now re-loaded the context in my head: this project is on 3.8 so bumping things to 3.9 won't cause any new incompat issues. Merging!) |
A quick fix to dd support for python 3.9 typing
Fixes: #31