-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brikk #12853
base: 0.9.x
Are you sure you want to change the base?
brikk #12853
Conversation
Co-authored-by: Minh Nguyen <[email protected]>
The root domain, chaijs.com, does not serve a valid certificate and gives a browser warning.
* Explain how to uninstall create-react-app globally * Add uninstallation intructions for yarn
Co-authored-by: Ian Schmitz <[email protected]>
Co-authored-by: Ian Schmitz <[email protected]>
Co-authored-by: Ian Schmitz <[email protected]> Co-authored-by: Ian Sutherland <[email protected]>
Co-authored-by: Ian Schmitz <[email protected]>
Update getting-started.md
Update adding-a-router.md
Update links in `README`
Chore: Update document to GitHub default branch
Update URL Co-authored-by: Nurlan Suyundukov <[email protected]>
Updated pace.js link
…ist-1.2.6 Bump minimist from 1.2.5 to 1.2.6
…ructions Chore: (Docs) Updates for the Storybook docs
docs: Make hyperlink consistent
docs: update jest links
When adding typescript to an existing Create React App project you have to have tsconfig.json in the project, I believe this change should clarify it for beginners getting stuck on this step. Not sure if providing an example would be too much so I have added a link to the tsconfig.json instead.
Add a link to React Router docs specific to adding routes.
Remove reference to deprecated VSCode debugger plugin. https://marketplace.visualstudio.com/items?itemName=msjsdiag.debugger-for-chrome
fix code splitting link
fix broken link progressive web app
docs: Add Link to Adding Routes Docs
update the heroku buildpack link
Add missing instruction if you are adding typescript
VSCode debugger plugin deprecated
yeah |
In #11318 a change was made to `babel-preset-react-app` to require `@babel/plugin-proposal-private-property-in-object`, but no such dependency was added to `package.json`. This fixes that mistake by adding the dependency.
Hi @Billydee87! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Beyond just a pure migration, this also: - Drops Node 14 usage from CI (which also removes the need for explicit npm 8 installs) - Removes the "old node" test, which just checked that installing on old node failed. We shouldn't need to test that - Consolidates the build & test workflows so we don't end up with a proliferation of workflows.
Update running-tests
Update running-tests.md
create-react-app-d960b9e38c062584ff6cfb1a70e1512509a966e7.zip