Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brikk #12853

Open
wants to merge 2,124 commits into
base: 0.9.x
Choose a base branch
from
Open

brikk #12853

wants to merge 2,124 commits into from

Conversation

Billydee87
Copy link

burkeholland and others added 30 commits June 14, 2020 16:01
The root domain, chaijs.com, does not serve a valid certificate
and gives a browser warning.
* Explain how to uninstall create-react-app globally

* Add uninstallation intructions for yarn
Co-authored-by: Ian Schmitz <[email protected]>
Co-authored-by: Ian Sutherland <[email protected]>
matrush and others added 24 commits June 17, 2022 10:05
Chore:  Update document to GitHub default branch
Update URL

Co-authored-by: Nurlan Suyundukov <[email protected]>
…ist-1.2.6

Bump minimist from 1.2.5 to 1.2.6
…ructions

Chore: (Docs) Updates for the Storybook docs
docs: Make hyperlink consistent
When adding typescript to an existing Create React App project you have to have tsconfig.json in the project, I believe this change should clarify it for beginners getting stuck on this step. Not sure if providing an example would be too much so I have added a link to the tsconfig.json instead.
Add a link to React Router docs specific to adding routes.
fix broken link progressive web app
docs: Add Link to Adding Routes Docs
update the heroku buildpack link
Add missing instruction if you are adding typescript
VSCode debugger plugin deprecated
@Billydee87
Copy link
Author

yeah

In #11318 a change was made to `babel-preset-react-app` to require `@babel/plugin-proposal-private-property-in-object`, but no such dependency was added to `package.json`. This fixes that mistake by adding the dependency.
@facebook-github-bot
Copy link

Hi @Billydee87!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

zpao and others added 3 commits June 14, 2023 13:58
Beyond just a pure migration, this also:

- Drops Node 14 usage from CI (which also removes the need for explicit
  npm 8 installs)
- Removes the "old node" test, which just checked that installing on old
  node failed. We shouldn't need to test that
- Consolidates the build & test workflows so we don't end up with
  a proliferation of workflows.
Update running-tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment