Update RC to use the extracted thread util classes #1040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D69584102 |
|
This pull request was exported from Phabricator. Differential Revision: D69584102 |
zielinskimz
added a commit
to zielinskimz/litho
that referenced
this pull request
Feb 13, 2025
Summary: Pull Request resolved: facebook#1040 This diff updates RenderCore to use the extracted thread util classes and removes the classes present in the main rendercore module. It also updates all callsites affected by this change by adding or updating the imports. Differential Revision: D69584102
zielinskimz
force-pushed
the
export-D69584102
branch
from
96c09be to
eedfd8e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69584102 |
zielinskimz
added a commit
to zielinskimz/litho
that referenced
this pull request
Feb 14, 2025
Summary: Pull Request resolved: facebook#1040 This diff updates RenderCore to use the extracted thread util classes and removes the classes present in the main rendercore module. It also updates all callsites affected by this change by adding or updating the imports. Differential Revision: D69584102
zielinskimz
force-pushed
the
export-D69584102
branch
from
eedfd8e to
baeb960
Compare
zielinskimz
added a commit
to zielinskimz/litho
that referenced
this pull request
Feb 14, 2025
Summary: Pull Request resolved: facebook#1040 This diff updates RenderCore to use the extracted thread util classes and removes the classes present in the main rendercore module. It also updates all callsites affected by this change by adding or updating the imports. Differential Revision: D69584102
zielinskimz
force-pushed
the
export-D69584102
branch
from
baeb960 to
500c88c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69584102 |
Summary: Copied rendercore-thread-utils into litho-rendercore-thread-utils using hg copy. ``` hg copy fbandroid/libraries/rendercore/rendercore-thread-utils/src fbandroid/libraries/components/litho-rendercore-thread-utils/ --force ``` Also enabled dir sync of rendercore-thread-utils directory so that the source code remains in sync between rendercore and litho. Differential Revision: D69525059
Summary: Pull Request resolved: facebook#1040 This diff updates RenderCore to use the extracted thread util classes and removes the classes present in the main rendercore module. It also updates all callsites affected by this change by adding or updating the imports. Differential Revision: D69584102
|
This pull request was exported from Phabricator. Differential Revision: D69584102 |
zielinskimz
force-pushed
the
export-D69584102
branch
from
500c88c to
04714e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff updates RenderCore to use the extracted thread util classes and removes the classes present in the main rendercore module.
It also updates all callsites affected by this change by adding or updating the imports.
Differential Revision: D69584102