Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @LooperMode LEGACY in tests that fail in PAUSED mode #762

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add @LooperMode LEGACY in tests that fail in PAUSED mode #762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2dbf23
Adds @LooperMode LEGACY in tests that fail in PAUSED mode
chggr Jan 26, 2021
7699fa4
Merge branch 'master' into loopermode-add
chggr Feb 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/AttachDetachHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class AttachDetachHandlerTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/CollectTransitionsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@
import org.junit.Test;
import org.junit.rules.ExpectedException;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class CollectTransitionsTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/CommonPropsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@
import org.junit.runner.RunWith;
import org.mockito.InOrder;
import org.mockito.Mockito;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class CommonPropsTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/ComponentGlobalKeyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@
import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class ComponentGlobalKeyTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/ComponentTreeMountTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class ComponentTreeMountTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/DeprecatedLithoTooltipTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@
import org.junit.runner.RunWith;
import org.mockito.Mock;
import org.mockito.MockitoAnnotations;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class DeprecatedLithoTooltipTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/InternalNodeResolvedPaddingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class InternalNodeResolvedPaddingTest {
private InternalNode mInternalNode;
Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/InternalNodeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class InternalNodeTest {
private static final int LIFECYCLE_TEST_ID = 1;
Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/InternalNodeTouchExpansionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class InternalNodeTouchExpansionTest {
private InternalNode mInternalNode;
Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/LayoutStateAddChildWithInputTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class LayoutStateAddChildWithInputTest {
private ComponentContext mContext;
Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/LayoutStateCalculateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,10 @@
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.Shadows;
import org.robolectric.annotation.LooperMode;
import org.robolectric.shadows.ShadowAccessibilityManager;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class LayoutStateCalculateTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/LayoutStateCalculateTopsAndBottomsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@
import java.util.List;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class LayoutStateCalculateTopsAndBottomsTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/LayoutStateCalculateVisibilityOutputsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class LayoutStateCalculateVisibilityOutputsTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/LayoutStateCreateTreeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.Config;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class LayoutStateCreateTreeTest {
private ComponentContext mComponentContext;
Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/LayoutStateEventHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class LayoutStateEventHandlerTest {
private int mUnspecifiedSizeSpec = 0; // SizeSpec.makeSizeSpec(0, SizeSpec.UNSPECIFIED);
Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/LayoutStateFutureReleaseTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,10 @@
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.Shadows;
import org.robolectric.annotation.LooperMode;
import org.robolectric.shadows.ShadowLooper;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class LayoutStateFutureReleaseTest {
private int mWidthSpec;
Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/LithoViewMountTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,13 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

/**
* Tests for {@link LithoView} and {@link MountState} to make sure mount only happens once when
* attaching the view and setting the component.
*/
@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class LithoViewMountTest {
private ComponentContext mContext;
Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/MountStateBetterLoggingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,10 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

/** Tests that Mount events are only logged when tracing is enabled. */
@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class MountStateBetterLoggingTest {
private ComponentContext mContext;
Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/MountStateBoundsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class MountStateBoundsTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/MountStateFocusableTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class MountStateFocusableTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/MountStateLoggingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,10 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

/** Tests that Mount events are only logged when tracing is enabled. */
@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class MountStateLoggingTest {
private ComponentContext mContext;
Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/MountStateRemountEventHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class MountStateRemountEventHandlerTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/MountStateRemountInPlaceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class MountStateRemountInPlaceTest {
private ComponentContext mContext;
Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/MountStateRemountTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class MountStateRemountTest {
private ComponentContext mContext;
Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/MountStateTestItemTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class MountStateTestItemTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/MountStateViewClickTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class MountStateViewClickTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/MountStateViewTagsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class MountStateViewTagsTest {
private static final int DUMMY_ID = 0x10000000;
Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/MountStateViewTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class MountStateViewTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/ResolveAttributeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class ResolveAttributeTest {
private ComponentContext mContext;
Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/ResolveResTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class ResolveResTest {
private ComponentContext mContext;
Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/TreeDiffingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class TreeDiffingTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/UniqueTransitionKeysTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@
import org.junit.Test;
import org.junit.rules.ExpectedException;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class UniqueTransitionKeysTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/ViewCompatComponentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,10 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

/** Tests {@link ViewCompatComponent} */
@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class ViewCompatComponentTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/ViewNodeInfoTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

/** Tests {@link ViewNodeInfo} */
@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class ViewNodeInfoTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/VisibilityEventsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.ParameterizedRobolectricTestRunner;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(ParameterizedRobolectricTestRunner.class)
public class VisibilityEventsTest {
private static final int LEFT = 0;
Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/WillRenderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@
import org.junit.Test;
import org.junit.rules.ExpectedException;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class WillRenderTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/YogaAlignBaselineTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class YogaAlignBaselineTest {

Expand Down
2 changes: 2 additions & 0 deletions litho-it/src/test/java/com/facebook/litho/widget/EditTextSpecTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,10 @@
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

/** Tests {@link EditText} component. */
@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class EditTextSpecTest {
@Rule public ComponentsRule mComponentsRule = new ComponentsRule();
Expand Down
Loading