Add OnLayoutCalculated component lifecycle method #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjaneczko
force-pushed
the
yoga-measure-lifecycle-method
branch
from
f9fddc5 to
7ab4216
Compare
tjaneczko
force-pushed
the
yoga-measure-lifecycle-method
branch
from
7ab4216 to
316383d
Compare
|
Is there any chance someone could take a look at this PR? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an
OnLayoutCalculatedcomponent lifecycle method, which allows LayoutSpec components to be notified when the Yoga layout calculation has completed. This is useful for measuring performance and debugging LayoutSpecs with regards to the amount of time their layout calculation takes.Changelog
OnLayoutCalculatedLayoutSpec component lifecycle method.Test Plan
Added unit tests to the
LayoutSpecLifecycleTestand ran them with:./gradlew :litho-it:testDebug --tests com.facebook.litho.LayoutSpecLifecycleTest*