New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CancelablePromise #1465

Open

Pterjudin wants to merge 1 commit into fastapi:master from Pterjudin:master

+67 −71

Pterjudin commented Jan 18, 2025

This PR improves code clarity and maintainability by:

Extracting repeated state checks into a isFinalState() helper.
Using ReadonlyArray for cancelHandlers for immutability.
Encapsulating onCancel logic in a createOnCancel() method.
Improving cancel() with better error handling and cleanup.
Adding explicit type annotations for private fields.
*Ensuring consistent use of semicolons and adding JSDoc comments.

NB:No changes to functionality; purely refactoring for readability and robustness.


          Update CancelablePromise.ts

57528cb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet