✅ Only run completion installation tests when the env var _TYPER_RUN_INSTALL_COMPLETION_TESTS is set
#995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svlandeg
commented
Sep 17, 2024
There was a problem hiding this comment.
This seems to be working as expected. On the CI's ubuntu-latest, there are no skipped tests (as before).
Locally, without setting any env var, with this PR I get
pytest tests/test_completion/test_completion_install.py
collected 5 items
tests/test_completion:test_completion_install.py sssss
On master, I get
pytest tests/test_completion/test_completion_install.py
collected 5 items
tests/test_completion/test_completion_install.py .....
i.e. these type of tests are now succesfully being skipped locally, while still running correctly on the CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #866 (comment), introducing a specific env var
_TYPER_RUN_INSTALL_COMPLETION_TESTSthat needs to be set before--install-completiontests are run. This env var is set for tests on the CI, but would usually not be set when users run tests locally. This is to ensure no side effects or failing tests happen locally. Fixes #413.Thanks to @rokbot for raising this issue in #866!