Support for multiple test summary Plists/destinations #20
Conversation
This prevents it from picking up duplicative “TestSummaries.plist” at the root of a result bundle.
|
Cool, thanks 👍 Do you think you can test this in production and ensure this doesn't break anything existing, and works with the new setup? |
|
I can't guarantee my availability to test it in production but I'll try. @CraigLn is this something you can test? |
| @@ -4,7 +4,7 @@ class TrainerAction < Action | |||
| def self.run(params) | |||
| require "trainer" | |||
|
|
|||
| params[:path] = Actions.lane_context[Actions::SharedValues::SCAN_GENERATED_PLIST_FILE] if Actions.lane_context[Actions::SharedValues::SCAN_GENERATED_PLIST_FILE] | |||
| params[:path] ||= Actions.lane_context[Actions::SharedValues::SCAN_GENERATED_PLIST_FILE] if Actions.lane_context[Actions::SharedValues::SCAN_GENERATED_PLIST_FILE] | |||
There was a problem hiding this comment.
If you weren't previously setting 'path' it will now always be '.' (the options default) even if SCAN_GENERATED_PLIST_FILE exists. If you want everything to be passive you could do something like this. I'm not sure what the best fix is for people using with/without Fastlane, since they're both assuming different default values.
Looks good; thanks for creating the PR.
|
Has any one tried this commit, needed this one as need to run multiple devices |
|
Any advice on what's preventing this from being merged? This would be really valuable for us :-) |
|
Any plans to merge this PR? It is 2 years old and I don't see why it is not in yet when everyone including me :) needs it. Time fly so, Xcode 11 supports test configurations which another test suite distinguish information needed to be added to JUnit.xml |
Related to #4.
This adds:
pathparameter via the Fastfile (0724404)It changes:
_TestSummaries.plist. This avoids creating output based on the duplicativeTestSummaries.plistfile in the root of the result bundle.