Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: introduce tasks to aid testing; update CI #151

Merged
merged 7 commits into from
Jan 29, 2025
Merged

Makefile: introduce tasks to aid testing; update CI #151

merged 7 commits into from
Jan 29, 2025

Conversation

cee-dub
Copy link
Collaborator

@cee-dub cee-dub commented Jan 28, 2025 •
edited
Loading

  • Adds a Makefile with tasks for testing across Go and TinyGo.
  • Updates the Github Actions workflows to use the make tasks.
  • Removes a dependency on wasmtime

@cee-dub cee-dub self-assigned this Jan 28, 2025
@cee-dub cee-dub mentioned this pull request Jan 28, 2025
Merged
@cee-dub cee-dub changed the title Makefile: introduce tasks to aid testing Makefile: introduce tasks to aid testing; update CI Jan 28, 2025
@cee-dub cee-dub requested a review from joeshaw January 28, 2025 22:00
@cee-dub cee-dub force-pushed the cee-dub/make-it-so branch from e17308d to 5d3d35a Compare January 28, 2025 22:14
@cee-dub
Copy link
Collaborator Author

cee-dub commented Jan 28, 2025

The failing validate workflow is fixed by changes in #150

@cee-dub cee-dub force-pushed the cee-dub/make-it-so branch from 5d3d35a to ad3387d Compare January 28, 2025 22:17
@cee-dub cee-dub force-pushed the cee-dub/make-it-so branch from a400480 to 182ac91 Compare January 28, 2025 22:35
@cee-dub
Copy link
Collaborator Author

cee-dub commented Jan 29, 2025

@joeshaw I think this is ready for a 👍

joeshaw
joeshaw approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@joeshaw joeshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 👍

@cee-dub cee-dub merged commit 05b9383 into main Jan 29, 2025
10 checks passed
@cee-dub cee-dub deleted the cee-dub/make-it-so branch January 29, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeshaw joeshaw joeshaw approved these changes

Assignees

@cee-dub cee-dub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cee-dub @joeshaw