fix(generators): Add FeathersGeneratorError #3556
Merged
+40
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daffl
changed the title
daffl
approved these changes
Feb 1, 2025
|
Thank you for putting this together. Will go out with the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several enhancements to improve code quality, error handling, and flexibility:
Custom Error Class: Provides more context in exceptions, making debugging and logging easier.
Prettier Configuration: Added more comprehensive formatting options to ensure consistent code style.
Default Version Parameter:
Before: Defaulted to 'latest' if no version was defined.
Now: Allows custom default versions for greater flexibility and control.
Improved Logical Operator:
Before: versions[dep] ? versions[dep] : 'latest'
Now: versions[dep] || defaultVersion for cleaner and more readable code.
Explicit Return Typing:
Added : string[] to improve type clarity and prevent errors.