bump proc-macro2 dep to pass nightly tests and add fail-fast-false #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying ferrous-systems-rust-exercises with
|
| Latest commit: |
ae22e68
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://94af105d.ferrous-systems-rust-exercises.pages.dev |
| Branch Preview URL: | https://canary-fail-fast-false.ferrous-systems-rust-exercises.pages.dev |
|
Did you run |
jonathanpallant
approved these changes
Feb 10, 2025
|
Manually, I didn't want to pull in the most recent version because that may have introduced more breaking changes, so I wanted a lower version if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR involves 2 small changes:
proc-macro2dependency to one that doesn't break on nightly (This was a well documented break then.)fail-fast: falseargument to the weekly canary to make it so if one stable/beta/nightly fails the other jobs still run.Should fix #168