-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed typescript checker output errors live update #217
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for vite-plugin-checker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
abd4d48
to
d6ef546
Compare
Sorry for the late response, could you provide a description of how to reproduce the issue the PR fixes? |
Its been a long time. |
Yeah, could you describe how to reproduce the duplicated error shown with minimal reproduction? If so, maybe we could check the root cause of this issue instead of prevent it from showing to userland. |
It's not prevent it from showing to userland, but when the multiple errors has been resolved, dialog will keep the resolved errors in dialog,until all the errors have been fixed. I can't reproduce the mistakes on my new machine may be related to computer performance.maybe ignore this PR. The previous reproduction code: const a = "";
a = 1; // first error
b = ""; // second error dialog show two errors. step.2 const a = "";
b = ""; // second error still keep then dialog will keep step 1 error in dialog,until all errors been resolved |
fixed overlay and terminal show error count not same as tsc message display errors count of typescript checker until all ts errors resovled.