Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow configuring custom typescriptPath #296

Merged
merged 5 commits into from
Feb 18, 2025

Conversation

DiFuks
Copy link
Contributor

@DiFuks DiFuks commented Jan 18, 2024

Close: #290

Copy link

changeset-bot bot commented Jan 18, 2024

🦋 Changeset detected

Latest commit: 2e3f9c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vite-plugin-checker Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for vite-plugin-checker ready!

Name Link
🔨 Latest commit 5bb8848
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-checker/deploys/67b41c116f414e0008d9a9f6
😎 Deploy Preview https://deploy-preview-296--vite-plugin-checker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DiFuks DiFuks mentioned this pull request Jan 18, 2024
3 tasks
@danielroe danielroe changed the title add support typescript path feat: allow configuring custom typescriptPath Feb 18, 2025
Copy link

pkg-pr-new bot commented Feb 18, 2025

Open in Stackblitz

npm i https://pkg.pr.new/vite-plugin-checker@296

commit: 5bb8848

@danielroe danielroe merged commit 945e9b0 into fi3ework:main Feb 18, 2025
10 checks passed
@danielroe danielroe mentioned this pull request Feb 18, 2025
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 21, 2025
| datasource | package             | from  | to    |
| ---------- | ------------------- | ----- | ----- |
| npm        | vite-plugin-checker | 0.8.0 | 0.9.0 |


## [v0.9.0](https://github.com/fi3ework/vite-plugin-checker/releases/tag/vite-plugin-checker%400.9.0)

#####    🚨 Breaking Changes

-   Drop support for `cjs` usage  -  by [@danielroe](https://github.com/danielroe) in fi3ework/vite-plugin-checker#452 [<samp>(155d7)</samp>](fi3ework/vite-plugin-checker@155d771)
-   **deps**: Upgrade to chokidar v4  -  by [@danielroe](https://github.com/danielroe) and [@stianjensen](https://github.com/stianjensen) in fi3ework/vite-plugin-checker#453 [<samp>(dc05e)</samp>](fi3ework/vite-plugin-checker@dc05e42)
-   **stylelint**: Require stylelint 16+ and update `meow`  -  by [@strawberry-choco](https://github.com/strawberry-choco) in fi3ework/vite-plugin-checker#294 [<samp>(3ec83)</samp>](fi3ework/vite-plugin-checker@3ec83ee)

#####    🚀 Features

-   Allow configuring custom `typescriptPath`  -  by [@fuks-ru](https://github.com/fuks-ru) in fi3ework/vite-plugin-checker#296 [<samp>(945e9)</samp>](fi3ework/vite-plugin-checker@945e9b0)

#####    🐞 Bug Fixes

-   Wait for checkers to finish before completing build  -  by [@philipgriffin](https://github.com/philipgriffin) and [@danielroe](https://github.com/danielroe) in fi3ework/vite-plugin-checker#288 [<samp>(a0d32)</samp>](fi3ework/vite-plugin-checker@a0d3281)
-   **biome**: Set `maxBuffer` size to infinity  -  by [@jonondarnad](https://github.com/jonondarnad) in fi3ework/vite-plugin-checker#417 [<samp>(939ab)</samp>](fi3ework/vite-plugin-checker@939abbb)

#####    🏎 Performance

-   Drop `fs-extra` in favour of native `node:fs`  -  by [@danielroe](https://github.com/danielroe) in fi3ework/vite-plugin-checker#444 [<samp>(94830)</samp>](fi3ework/vite-plugin-checker@9483051)
-   Remove unused dependencies  -  by [@danielroe](https://github.com/danielroe) [<samp>(fc0bc)</samp>](fi3ework/vite-plugin-checker@fc0bcd6)
-   Switch to `colorette`  -  by [@danielroe](https://github.com/danielroe) [<samp>(2a745)</samp>](fi3ework/vite-plugin-checker@2a745f8)

#####     [View changes on GitHub](https://github.com/fi3ework/vite-plugin-checker/compare/[email protected]@0.9.0)
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 21, 2025
| datasource | package             | from  | to    |
| ---------- | ------------------- | ----- | ----- |
| npm        | vite-plugin-checker | 0.8.0 | 0.9.0 |


## [v0.9.0](https://github.com/fi3ework/vite-plugin-checker/releases/tag/vite-plugin-checker%400.9.0)

#####    🚨 Breaking Changes

-   Drop support for `cjs` usage  -  by [@danielroe](https://github.com/danielroe) in fi3ework/vite-plugin-checker#452 [<samp>(155d7)</samp>](fi3ework/vite-plugin-checker@155d771)
-   **deps**: Upgrade to chokidar v4  -  by [@danielroe](https://github.com/danielroe) and [@stianjensen](https://github.com/stianjensen) in fi3ework/vite-plugin-checker#453 [<samp>(dc05e)</samp>](fi3ework/vite-plugin-checker@dc05e42)
-   **stylelint**: Require stylelint 16+ and update `meow`  -  by [@strawberry-choco](https://github.com/strawberry-choco) in fi3ework/vite-plugin-checker#294 [<samp>(3ec83)</samp>](fi3ework/vite-plugin-checker@3ec83ee)

#####    🚀 Features

-   Allow configuring custom `typescriptPath`  -  by [@fuks-ru](https://github.com/fuks-ru) in fi3ework/vite-plugin-checker#296 [<samp>(945e9)</samp>](fi3ework/vite-plugin-checker@945e9b0)

#####    🐞 Bug Fixes

-   Wait for checkers to finish before completing build  -  by [@philipgriffin](https://github.com/philipgriffin) and [@danielroe](https://github.com/danielroe) in fi3ework/vite-plugin-checker#288 [<samp>(a0d32)</samp>](fi3ework/vite-plugin-checker@a0d3281)
-   **biome**: Set `maxBuffer` size to infinity  -  by [@jonondarnad](https://github.com/jonondarnad) in fi3ework/vite-plugin-checker#417 [<samp>(939ab)</samp>](fi3ework/vite-plugin-checker@939abbb)

#####    🏎 Performance

-   Drop `fs-extra` in favour of native `node:fs`  -  by [@danielroe](https://github.com/danielroe) in fi3ework/vite-plugin-checker#444 [<samp>(94830)</samp>](fi3ework/vite-plugin-checker@9483051)
-   Remove unused dependencies  -  by [@danielroe](https://github.com/danielroe) [<samp>(fc0bc)</samp>](fi3ework/vite-plugin-checker@fc0bcd6)
-   Switch to `colorette`  -  by [@danielroe](https://github.com/danielroe) [<samp>(2a745)</samp>](fi3ework/vite-plugin-checker@2a745f8)

#####     [View changes on GitHub](https://github.com/fi3ework/vite-plugin-checker/compare/[email protected]@0.9.0)
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 22, 2025
| datasource | package             | from  | to    |
| ---------- | ------------------- | ----- | ----- |
| npm        | vite-plugin-checker | 0.8.0 | 0.9.0 |


## [v0.9.0](https://github.com/fi3ework/vite-plugin-checker/releases/tag/vite-plugin-checker%400.9.0)

#####    🚨 Breaking Changes

-   Drop support for `cjs` usage  -  by [@danielroe](https://github.com/danielroe) in fi3ework/vite-plugin-checker#452 [<samp>(155d7)</samp>](fi3ework/vite-plugin-checker@155d771)
-   **deps**: Upgrade to chokidar v4  -  by [@danielroe](https://github.com/danielroe) and [@stianjensen](https://github.com/stianjensen) in fi3ework/vite-plugin-checker#453 [<samp>(dc05e)</samp>](fi3ework/vite-plugin-checker@dc05e42)
-   **stylelint**: Require stylelint 16+ and update `meow`  -  by [@strawberry-choco](https://github.com/strawberry-choco) in fi3ework/vite-plugin-checker#294 [<samp>(3ec83)</samp>](fi3ework/vite-plugin-checker@3ec83ee)

#####    🚀 Features

-   Allow configuring custom `typescriptPath`  -  by [@fuks-ru](https://github.com/fuks-ru) in fi3ework/vite-plugin-checker#296 [<samp>(945e9)</samp>](fi3ework/vite-plugin-checker@945e9b0)

#####    🐞 Bug Fixes

-   Wait for checkers to finish before completing build  -  by [@philipgriffin](https://github.com/philipgriffin) and [@danielroe](https://github.com/danielroe) in fi3ework/vite-plugin-checker#288 [<samp>(a0d32)</samp>](fi3ework/vite-plugin-checker@a0d3281)
-   **biome**: Set `maxBuffer` size to infinity  -  by [@jonondarnad](https://github.com/jonondarnad) in fi3ework/vite-plugin-checker#417 [<samp>(939ab)</samp>](fi3ework/vite-plugin-checker@939abbb)

#####    🏎 Performance

-   Drop `fs-extra` in favour of native `node:fs`  -  by [@danielroe](https://github.com/danielroe) in fi3ework/vite-plugin-checker#444 [<samp>(94830)</samp>](fi3ework/vite-plugin-checker@9483051)
-   Remove unused dependencies  -  by [@danielroe](https://github.com/danielroe) [<samp>(fc0bc)</samp>](fi3ework/vite-plugin-checker@fc0bcd6)
-   Switch to `colorette`  -  by [@danielroe](https://github.com/danielroe) [<samp>(2a745)</samp>](fi3ework/vite-plugin-checker@2a745f8)

#####     [View changes on GitHub](https://github.com/fi3ework/vite-plugin-checker/compare/[email protected]@0.9.0)
@pksunkara
Copy link

This seems to make typescript checker crash when used with pnpm.

Config

    checker({
      typescript: {
        tsconfigPath: './assets/tsconfig.json',
      },
    }),

Error

1|fullstack-dev-assets  | > @advisory/[email protected] dev-assets /home/project/packages/fullstack
1|fullstack-dev-assets  | > vite dev
1|fullstack-dev-assets  |   VITE v5.4.14  ready in 945 ms
1|fullstack-dev-assets  |   ➜  Local:   http://localhost:3000/
1|fullstack-dev-assets  |   ➜  Network: use --host to expose
1|fullstack-dev-assets  | file:///home/project/node_modules/.pnpm/[email protected][email protected][email protected][email protected][email protected]_@[email protected]_/node_modules/vite-plugin-checker/dist/checkers/typescript/main.js:46
1|fullstack-dev-assets  |         ts.sys.fileExists,
1|fullstack-dev-assets  |                ^
1|fullstack-dev-assets  | TypeError [Error]: Cannot read properties of undefined (reading 'fileExists')
1|fullstack-dev-assets  |     at Object.configureServer (file:///home/project/node_modules/.pnpm/[email protected][email protected][email protected][email protected][email protected]_@[email protected]_/node_modules/vite-plugin-checker/dist/checkers/typescript/main.js:46:16)
1|fullstack-dev-assets  |  ELIFECYCLE  Command failed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing a custom path to TypeScript
3 participants