Persist popup open/close state to avoid closing it every page refresh #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store userCollapsed in sessionStorage to avoid closing it every page refresh
✅ Deploy Preview for vite-plugin-checker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
armano2
reviewed
Feb 17, 2025
packages/runtime/src/App.ce.vue
Outdated
| @@ -44,10 +44,11 @@ if (props?.overlayConfig?.initialIsOpen === 'error') { | |||
| }) | |||
| } | |||
|
|
|||
| const userCollapsed = ref<boolean | undefined>(undefined) | |||
| const userCollapsed = ref<boolean>(sessionStorage.userCollapsed === "true") | |||
There was a problem hiding this comment.
great idea, can you change name to something more unique to avoid potential conflicts?
maybe something like vite_checker_overlay_collapsed
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store userCollapsed in sessionStorage to avoid closing it every page refresh.
NOTE: you can improve the PR making it configurable, store it in another sessionStorage[KEY].