New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build!: drop support for `cjs` usage #452

Merged

danielroe merged 4 commits into main from chore/major-deps

Feb 18, 2025

Collaborator

danielroe commented Feb 18, 2025 •

edited

Loading

both of these major version updates drop CJS support

as this is a vite plugin, I think it's safe not to support cjs

closes #277
closes #184


          chore(deps): update npm-run-path and strip-ansi

f7cb1b9

netlify bot commented Feb 18, 2025 •

edited

Loading

✅ Deploy Preview for vite-plugin-checker ready!

Name	Link
🔨 Latest commit	`a5a5f70`
🔍 Latest deploy log	https://app.netlify.com/sites/vite-plugin-checker/deploys/67b40fc8a8608b00083d4e46
😎 Deploy Preview	https://deploy-preview-452--vite-plugin-checker.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


          build!: drop support for cjs usage

3bd7eb7

danielroe changed the title ~~chore(deps): update npm-run-path and strip-ansi~~ build!: drop support for cjs usage

pkg-pr-new bot commented Feb 18, 2025 •

edited

Loading

Open in Stackblitz

npm i https://pkg.pr.new/vite-plugin-checker@452

commit: a5a5f70

danielroe marked this pull request as ready for review

February 18, 2025 04:36

danielroe added 2 commits

February 18, 2025 05:42


          chore: drop cjs testing

c4141c8


          fix: update relative runtime source path

a5a5f70

danielroe merged commit 155d771 into main

10 checks passed

danielroe deleted the chore/major-deps branch

February 18, 2025 04:59

danielroe mentioned this pull request

Merged

renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request


          Update dependency vite-plugin-checker to v0.9.0

06bda37

| datasource | package             | from  | to    |
| ---------- | ------------------- | ----- | ----- |
| npm        | vite-plugin-checker | 0.8.0 | 0.9.0 |


## [v0.9.0](https://github.com/fi3ework/vite-plugin-checker/releases/tag/vite-plugin-checker%400.9.0)

#####    🚨 Breaking Changes

-   Drop support for `cjs` usage  -  by [@danielroe](https://github.com/danielroe) in fi3ework/vite-plugin-checker#452 [<samp>(155d7)</samp>](fi3ework/vite-plugin-checker@155d771)
-   **deps**: Upgrade to chokidar v4  -  by [@danielroe](https://github.com/danielroe) and [@stianjensen](https://github.com/stianjensen) in fi3ework/vite-plugin-checker#453 [<samp>(dc05e)</samp>](fi3ework/vite-plugin-checker@dc05e42)
-   **stylelint**: Require stylelint 16+ and update `meow`  -  by [@strawberry-choco](https://github.com/strawberry-choco) in fi3ework/vite-plugin-checker#294 [<samp>(3ec83)</samp>](fi3ework/vite-plugin-checker@3ec83ee)

#####    🚀 Features

-   Allow configuring custom `typescriptPath`  -  by [@fuks-ru](https://github.com/fuks-ru) in fi3ework/vite-plugin-checker#296 [<samp>(945e9)</samp>](fi3ework/vite-plugin-checker@945e9b0)

#####    🐞 Bug Fixes

-   Wait for checkers to finish before completing build  -  by [@philipgriffin](https://github.com/philipgriffin) and [@danielroe](https://github.com/danielroe) in fi3ework/vite-plugin-checker#288 [<samp>(a0d32)</samp>](fi3ework/vite-plugin-checker@a0d3281)
-   **biome**: Set `maxBuffer` size to infinity  -  by [@jonondarnad](https://github.com/jonondarnad) in fi3ework/vite-plugin-checker#417 [<samp>(939ab)</samp>](fi3ework/vite-plugin-checker@939abbb)

#####    🏎 Performance

-   Drop `fs-extra` in favour of native `node:fs`  -  by [@danielroe](https://github.com/danielroe) in fi3ework/vite-plugin-checker#444 [<samp>(94830)</samp>](fi3ework/vite-plugin-checker@9483051)
-   Remove unused dependencies  -  by [@danielroe](https://github.com/danielroe) [<samp>(fc0bc)</samp>](fi3ework/vite-plugin-checker@fc0bcd6)
-   Switch to `colorette`  -  by [@danielroe](https://github.com/danielroe) [<samp>(2a745)</samp>](fi3ework/vite-plugin-checker@2a745f8)

#####     [View changes on GitHub](https://github.com/fi3ework/vite-plugin-checker/compare/[email protected]@0.9.0)

renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request


          Update dependency vite-plugin-checker to v0.9.0

468d0ce

| datasource | package             | from  | to    |
| ---------- | ------------------- | ----- | ----- |
| npm        | vite-plugin-checker | 0.8.0 | 0.9.0 |


## [v0.9.0](https://github.com/fi3ework/vite-plugin-checker/releases/tag/vite-plugin-checker%400.9.0)

#####    🚨 Breaking Changes

-   Drop support for `cjs` usage  -  by [@danielroe](https://github.com/danielroe) in fi3ework/vite-plugin-checker#452 [<samp>(155d7)</samp>](fi3ework/vite-plugin-checker@155d771)
-   **deps**: Upgrade to chokidar v4  -  by [@danielroe](https://github.com/danielroe) and [@stianjensen](https://github.com/stianjensen) in fi3ework/vite-plugin-checker#453 [<samp>(dc05e)</samp>](fi3ework/vite-plugin-checker@dc05e42)
-   **stylelint**: Require stylelint 16+ and update `meow`  -  by [@strawberry-choco](https://github.com/strawberry-choco) in fi3ework/vite-plugin-checker#294 [<samp>(3ec83)</samp>](fi3ework/vite-plugin-checker@3ec83ee)

#####    🚀 Features

-   Allow configuring custom `typescriptPath`  -  by [@fuks-ru](https://github.com/fuks-ru) in fi3ework/vite-plugin-checker#296 [<samp>(945e9)</samp>](fi3ework/vite-plugin-checker@945e9b0)

#####    🐞 Bug Fixes

-   Wait for checkers to finish before completing build  -  by [@philipgriffin](https://github.com/philipgriffin) and [@danielroe](https://github.com/danielroe) in fi3ework/vite-plugin-checker#288 [<samp>(a0d32)</samp>](fi3ework/vite-plugin-checker@a0d3281)
-   **biome**: Set `maxBuffer` size to infinity  -  by [@jonondarnad](https://github.com/jonondarnad) in fi3ework/vite-plugin-checker#417 [<samp>(939ab)</samp>](fi3ework/vite-plugin-checker@939abbb)

#####    🏎 Performance

-   Drop `fs-extra` in favour of native `node:fs`  -  by [@danielroe](https://github.com/danielroe) in fi3ework/vite-plugin-checker#444 [<samp>(94830)</samp>](fi3ework/vite-plugin-checker@9483051)
-   Remove unused dependencies  -  by [@danielroe](https://github.com/danielroe) [<samp>(fc0bc)</samp>](fi3ework/vite-plugin-checker@fc0bcd6)
-   Switch to `colorette`  -  by [@danielroe](https://github.com/danielroe) [<samp>(2a745)</samp>](fi3ework/vite-plugin-checker@2a745f8)

#####     [View changes on GitHub](https://github.com/fi3ework/vite-plugin-checker/compare/[email protected]@0.9.0)

renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request


          Update dependency vite-plugin-checker to v0.9.0

da942b2

| datasource | package             | from  | to    |
| ---------- | ------------------- | ----- | ----- |
| npm        | vite-plugin-checker | 0.8.0 | 0.9.0 |


## [v0.9.0](https://github.com/fi3ework/vite-plugin-checker/releases/tag/vite-plugin-checker%400.9.0)

#####    🚨 Breaking Changes

-   Drop support for `cjs` usage  -  by [@danielroe](https://github.com/danielroe) in fi3ework/vite-plugin-checker#452 [<samp>(155d7)</samp>](fi3ework/vite-plugin-checker@155d771)
-   **deps**: Upgrade to chokidar v4  -  by [@danielroe](https://github.com/danielroe) and [@stianjensen](https://github.com/stianjensen) in fi3ework/vite-plugin-checker#453 [<samp>(dc05e)</samp>](fi3ework/vite-plugin-checker@dc05e42)
-   **stylelint**: Require stylelint 16+ and update `meow`  -  by [@strawberry-choco](https://github.com/strawberry-choco) in fi3ework/vite-plugin-checker#294 [<samp>(3ec83)</samp>](fi3ework/vite-plugin-checker@3ec83ee)

#####    🚀 Features

-   Allow configuring custom `typescriptPath`  -  by [@fuks-ru](https://github.com/fuks-ru) in fi3ework/vite-plugin-checker#296 [<samp>(945e9)</samp>](fi3ework/vite-plugin-checker@945e9b0)

#####    🐞 Bug Fixes

-   Wait for checkers to finish before completing build  -  by [@philipgriffin](https://github.com/philipgriffin) and [@danielroe](https://github.com/danielroe) in fi3ework/vite-plugin-checker#288 [<samp>(a0d32)</samp>](fi3ework/vite-plugin-checker@a0d3281)
-   **biome**: Set `maxBuffer` size to infinity  -  by [@jonondarnad](https://github.com/jonondarnad) in fi3ework/vite-plugin-checker#417 [<samp>(939ab)</samp>](fi3ework/vite-plugin-checker@939abbb)

#####    🏎 Performance

-   Drop `fs-extra` in favour of native `node:fs`  -  by [@danielroe](https://github.com/danielroe) in fi3ework/vite-plugin-checker#444 [<samp>(94830)</samp>](fi3ework/vite-plugin-checker@9483051)
-   Remove unused dependencies  -  by [@danielroe](https://github.com/danielroe) [<samp>(fc0bc)</samp>](fi3ework/vite-plugin-checker@fc0bcd6)
-   Switch to `colorette`  -  by [@danielroe](https://github.com/danielroe) [<samp>(2a745)</samp>](fi3ework/vite-plugin-checker@2a745f8)

#####     [View changes on GitHub](https://github.com/fi3ework/vite-plugin-checker/compare/[email protected]@0.9.0)

kerukukku1 commented Feb 28, 2025

@danielroe
I don't think breaking changes like dropping support for CJS should be introduced in a minor version update...

Collaborator Author

danielroe commented Feb 28, 2025

@kerukukku1 below v1, incrementing the second digit of a semver version is acceptable for a major version update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet