fix: Make batch sealing retry correct #367
Open
+475
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
force-pushed
the
fix/supra-robustness
branch
from
e428655 to
6fded64
Compare
magik6k
force-pushed
the
fix/supra-robustness
branch
from
6fded64 to
e4b9bfd
Compare
magik6k
force-pushed
the
fix/supra-robustness
branch
from
200fe5d to
f555428
Compare
magik6k
force-pushed
the
fix/supra-robustness
branch
from
23cb1bc to
4caf9ad
Compare
magik6k
changed the title
magik6k
requested review from
LexLuthr and
snadrus
and removed request for
LexLuthr
snadrus
approved these changes
Jan 14, 2025
snadrus
reviewed
Jan 14, 2025
| PipelineSlot uint64 `db:"pipeline_slot"` | ||
| } | ||
| err := db.Select(context.Background(), &slotRefs, | ||
| `SELECT sp_id, sector_number, pipeline_slot FROM batch_sector_refs WHERE machine_host_and_port = $1`, |
There was a problem hiding this comment.
what if it crashed last time? Will db values get stuck in use?
LexLuthr
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main bug this is fixing is making the reference tracker survive restarts, and making C1 code correctly recompute partial output.
Plus some smaller defensive measures + new metrics.