Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lotus-infra public and archive lotus-infra-archive #78

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

BigLep
Copy link
Member

@BigLep BigLep commented Sep 19, 2024

This is being done in support of filecoin-project/lotus-infra#1631

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@BigLep BigLep requested a review from a team as a code owner September 19, 2024 21:11
@BigLep BigLep requested a review from rjan90 September 19, 2024 21:11
@BigLep BigLep self-assigned this Sep 19, 2024
Copy link
Contributor

The following access changes will be introduced as a result of applying the plan:

Access Changes
User aarshkshah1992:
  - will lose admin permission to lotus-infra-archive
User biglep:
  - will lose admin permission to lotus-infra-archive
User jennijuju:
  - will lose admin permission to lotus-infra-archive
User kubuxu:
  - will lose admin permission to lotus-infra-archive
User magik6k:
  - will lose admin permission to lotus-infra-archive
User masih:
  - will lose admin permission to lotus-infra-archive
User rjan90:
  - will lose admin permission to lotus-infra-archive
User rvagg:
  - will lose admin permission to lotus-infra-archive
User stebalien:
  - will lose admin permission to lotus-infra-archive
User tippyflitsuk:
  - will lose admin permission to lotus-infra-archive
User zenground0:
  - will lose admin permission to lotus-infra-archive

Copy link
Contributor

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

filecoin-project

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # github_repository.this["lotus-infra"] will be updated in-place
  ~ resource "github_repository" "this" {
        id                          = "lotus-infra"
        name                        = "lotus-infra"
      ~ visibility                  = "private" -> "public"
        # (31 unchanged attributes hidden)

      + security_and_analysis {

          + secret_scanning {
              + status = "enabled"
            }

          + secret_scanning_push_protection {
              + status = "enabled"
            }
        }
    }

  # github_repository.this["lotus-infra-archive"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "lotus-infra-archive"
        name                        = "lotus-infra-archive"
        # (32 unchanged attributes hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

@BigLep BigLep merged commit 53a65d8 into master Sep 20, 2024
6 checks passed
@BigLep
Copy link
Member Author

BigLep commented Sep 20, 2024

The job failed but then I just made the repo public and enabled secret scanning:
image
image

I assume Sunday's sync workflow will fix up the state. Otherwise I'll look into this more Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants