Remove manifest versions #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
steb/remove-manifest-versions
branch
from
d21b9bd
to
e74d3b2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
==========================================
+ Coverage 81.16% 81.56% +0.39%
==========================================
Files 41 41
Lines 3652 3666 +14
==========================================
+ Hits 2964 2990 +26
+ Misses 408 396 -12
Partials 280 280
|
Stebalien
force-pushed
the
steb/remove-manifest-versions
branch
from
e74d3b2
to
9ae7b8c
Compare
This also allows us to re-config without re-bootstrap (by restarting the local F3 instance). This is only safe for non-consensus parameters and will be horribly unsafe until we fix #392. Also: - Removes reliance on hashing json, relies on the network name and manual equality checks. - Removes versions. We now expect the version to be explicitly specified in the network name. - Starts message sequence numbers at the current time so we don't need to save them. - Remove the EC from the dynamic manifest provider as it's unused. - Tests. fixes #468
Stebalien
force-pushed
the
steb/remove-manifest-versions
branch
from
9ae7b8c
to
9b6dd91
Compare
Kubuxu
reviewed
Jul 13, 2024
Stebalien
force-pushed
the
steb/remove-manifest-versions
branch
from
2232040
to
f23b8ae
Compare
Kubuxu
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also allows us to re-config without re-bootstrap (by restarting the local F3 instance). This is only safe for non-consensus parameters and will be horribly unsafe until we fix 392.
Also:
fixes #468