chore: upgrade to the latest go-f3 and allow F3 chain exchange topics #12839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
changed the title
masih
force-pushed
the
masih/f3-dep-up-chainex
branch
from
b2e443d to
0a406e1
Compare
4 tasks
masih
force-pushed
the
masih/f3-dep-up-chainex
branch
2 times, most recently
from
fcfeb34 to
90eb3e7
Compare
Upgrade to the latest `go-f3` and add the F3 chain exchange topics to the allowed topic list for both static and dynamic manifests. Fixes filecoin-project/go-f3#809
The open API uses reflection to infer json schema. This means it does not pick up the custom encoders for the types.
masih
force-pushed
the
masih/f3-dep-up-chainex
branch
from
dc8fe2c to
0b6029d
Compare
8 tasks
`e232882cba7171e5097b5b12870af19d9256d3a7`
`ac4d25d52d2f48285b503046e3d30ae766ee7ffa`
Log failure to run CLI command Prior code only conditionally logged the output when `LOTUS_DEV` env var was present. This doesn't make sense for a number of reasons: * In case of an error starting up `lotus daemon` via systemctl for example the logs would miss the error. One then has to search through system journal to see what happened. * There are no other places that I can find where `LOTUS_DEV` env var is used. The commit that introduced this condition is very old with no clear commit message to shed light into the rationale. For the first reason alone, the changes here remove that condition, and log the message when the logging output is not standard err or out. This way we at least cover the case where lotus is run in a production environment and would avoid partial logging of errors. (cherry picked from commit bb70977)
`a2b3c6601f7fe4375e51b939ae86bd4638916060`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Upgrade to the latest
go-f3and add the F3 chain exchange topics to the allowed topic list for both static and dynamic manifests.Fixes filecoin-project/go-f3#809
Blocked by making a new concrete F3 release.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: