-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): add stale branch workflow #12858
Conversation
ci: add stale branch workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good to merge, but a couple of questions coming to mind:
- What does denoting a branch as "stale" do?
- What kind of communication is there that a branch is about to be deleted?
chore: update regex-filter
Co-authored-by: Steve Loeppky <[email protected]>
let's land it with dry-run and observe the output the first time it runs and see if there are any surprises |
Agree on landing it with dry-run initially so that we can inspect the logs of the workflow firs. After diving deeper into the workflow today to answer some of Steve's questions, it also seems like an initial manual cleanup of the branches would be the best approach before landing this workflow, as well as some additional parameter tweaks:
Given that we have 600+ branches, and most of these branches already are stale, it could quickly get a bit spammy without a initial cleanup, although the max amount of of stale branch issues that can exist at the same time is 20. I will start with the manual cleanup, and then tweak the parameters. |
All sounds good @rjan90 . Also, I think it probably makes sense to document what some of the default are in the workflow (e.g., protoected branches excluded) or just add the value explicitly in so it's self documenting. |
chore: document values in workflow
I have updated the workflow with comments and explicitly set defaults to make it more self-descriptive. The 'dry-run' option has been set to true, allowing us to observe the behavior first. Additionally, I have completed an initial cleanup of old branches, reducing the total from 647 to 161. |
Co-authored-by: Piotr Galar <[email protected]>
Proposed Changes
Add a workflow that marks stale branches and deletes stale branches:
Checklist
Before you mark the PR ready for review, please make sure that: