Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Removed sln file #16804

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cd-sideload-preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
configuration: [Release]
platform: [x64]
env:
SOLUTION_NAME: 'Files.sln'
SOLUTION_NAME: 'Files.slnx'
CONFIGURATION: '${{ matrix.configuration }}'
PLATFORM: '${{ matrix.platform }}'
APPX_BUNDLE_PLATFORMS: 'x64|arm64'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cd-sideload-stable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
configuration: [Release]
platform: [x64]
env:
SOLUTION_NAME: 'Files.sln'
SOLUTION_NAME: 'Files.slnx'
CONFIGURATION: '${{ matrix.configuration }}'
PLATFORM: '${{ matrix.platform }}'
APPX_BUNDLE_PLATFORMS: 'x64|arm64'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cd-store-preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
configuration: [Release]
platform: [x64]
env:
SOLUTION_NAME: 'Files.sln'
SOLUTION_NAME: 'Files.slnx'
CONFIGURATION: '${{ matrix.configuration }}'
PLATFORM: '${{ matrix.platform }}'
APPX_BUNDLE_PLATFORMS: 'x64|arm64'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cd-store-stable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
configuration: [Release]
platform: [x64]
env:
SOLUTION_NAME: 'Files.sln'
SOLUTION_NAME: 'Files.slnx'
CONFIGURATION: '${{ matrix.configuration }}'
PLATFORM: '${{ matrix.platform }}'
APPX_BUNDLE_PLATFORMS: 'x64|arm64'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ run-name: ${{ github.event_name == 'pull_request' && 'Files PR Validation' || 'F

env:
WORKING_DIR: ${{ github.workspace }} # Default: 'D:\a\Files\Files'
SOLUTION_PATH: '${{ github.workspace }}\Files.sln'
SOLUTION_PATH: '${{ github.workspace }}\Files.slnx'
PACKAGE_PROJECT_DIR: '${{ github.workspace }}\src\Files.App (Package)'
PACKAGE_PROJECT_PATH: '${{ github.workspace }}\src\Files.App (Package)\Files.Package.wapproj'
AUTOMATED_TESTS_ARCHITECTURE: 'x64'
Expand Down
318 changes: 0 additions & 318 deletions Files.sln

This file was deleted.

2 changes: 1 addition & 1 deletion global.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the global.json file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use global.json to ensure a minimum version of .NET SDK so that people won't use an incorrect one that doesn't support slnx.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update our docs to reflect this change

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "9.0.102",
"version": "9.0.200",
"rollForward": "latestMajor"
}
}
Loading