Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency mismatches in Gemfile.lock and Podfile.lock for TestProjectLatestRN #146

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

erayaydin
Copy link

This PR resolves inconsistencies in dependency lock files caused by previous commits.

Changes:

  • Gemfile.lock:
    • Downgraded concurrent-ruby from 1.3.5 to 1.3.3 to align with the constraint concurrent-ruby (< 1.3.4) in Gemfile.
    • Ensures bundle install produces consistent results.
  • Podfile.lock:
    • Reverted unintended CocoaPods upgrade from 1.15.2 to 1.16.2.
    • Updated Yoga checksum to match the correct version.
    • Prevents issues caused by mismatched CocoaPods versions.

These changes restore proper dependency versions and prevent potential build/runtime issues and warnings.

@erayaydin erayaydin added bug Something isn't working dependencies Pull requests that update a dependency file labels Feb 14, 2025
@erayaydin erayaydin self-assigned this Feb 14, 2025
Copy link

github-actions bot commented Feb 14, 2025

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 47.14% 66/140
🔴 Branches 38.78% 19/49
🔴 Functions 43.9% 18/41
🔴 Lines 45.59% 62/136

Test suite run success

21 tests passing in 3 suites.

Report generated by 🧪jest coverage report action from 2d31050

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🔴 All files 47.14 38.77 43.9 45.58
🟡  FingerprintJsProAgent.ts 76.92 76.47 100 76.92 39,59-62,95,103
🟡  FingerprintJsProContext.ts 75 100 0 75 5
🟢  FingerprintJsProProvider.tsx 93.33 50 100 93.33 44
🔴  errors.ts 15.38 10.71 15.38 15.38 8-33,56-249,272-285,332-336,343-379,383
🔴  index.ts 0 0 0 0
🔴  types.ts 0 0 0 0
🟢  useVisitorData.ts 100 100 100 100

@erayaydin
Copy link
Author

erayaydin commented Feb 14, 2025

Since the test project is within the SDK and commits are fix, a hotfix version increment will occur. Are we sure we want to do like this, @ilfa ? I can change these changes to chore if you want.

@erayaydin erayaydin changed the title Fix dependency mismatches in Gemfile.lock and Podfile.lock Fix dependency mismatches in Gemfile.lock and Podfile.lock for TestProjectLatestRN Feb 14, 2025
@erayaydin erayaydin marked this pull request as ready for review February 14, 2025 16:38
…t-ruby dependency constraint

Ensure Gemfile.lock reflects the constraint `concurrent-ruby (< 1.3.4)`
by downgrading `concurrent-ruby` from `1.3.5` to `1.3.3`.

This resolves inconsistency between `Gemfile` and `Gemfile.lock`.

Related-Task: INTER-1117
…ds version

Revert unintended CocoaPods upgrade from 1.15.2 to 1.16.2 and update Yoga
checksum accordingly.

This fixes an issue caused by incorrect CocoaPods usage in a previous commit.

Related-Task: INTER-1117
@erayaydin erayaydin force-pushed the fix/gemfile-concurrent-ruby-podfile-cocoapods branch from 5402007 to 2d31050 Compare February 17, 2025 10:44
Copy link

This PR will not create a new release 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants