Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate podspec from Ruby DSL to JSON format #147

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Migrate podspec from Ruby DSL to JSON format #147

wants to merge 1 commit into from

Conversation

erayaydin
Copy link

This PR migrates the RNFingerprintjsPro podspec from Ruby DSL format to JSON format. This change simplifies the podspec definition and allows for easier access to dependencies.

Changes:

  • Created JSON format with pod helper: pod ipc spec RNFingerprintjsPro.podspec > RNFingerprintjsPro.podspec.json
  • Deleted the Ruby DSL based RNFingerprintjsPro.podspec file.

@erayaydin erayaydin added the enhancement New feature or request label Feb 14, 2025
@erayaydin erayaydin self-assigned this Feb 14, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🔴 Statements 47.14% 66/140
🔴 Branches 38.78% 19/49
🔴 Functions 43.9% 18/41
🔴 Lines 45.59% 62/136

Test suite run success

21 tests passing in 3 suites.

Report generated by 🧪jest coverage report action from 0b48249

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🔴 All files 47.14 38.77 43.9 45.58
🟡  FingerprintJsProAgent.ts 76.92 76.47 100 76.92 39,59-62,95,103
🟡  FingerprintJsProContext.ts 75 100 0 75 5
🟢  FingerprintJsProProvider.tsx 93.33 50 100 93.33 44
🔴  errors.ts 15.38 10.71 15.38 15.38 8-33,56-249,272-285,332-336,343-379,383
🔴  index.ts 0 0 0 0
🔴  types.ts 0 0 0 0
🟢  useVisitorData.ts 100 100 100 100

@erayaydin
chore(podspec): migrate podspec from Ruby DSL to JSON format
0b48249 
Switched from Ruby DSL podspec to JSON format for easier access
to dependencies and a simplified podspec definition.

Related-Task: INTER-1118
@erayaydin erayaydin force-pushed the feature/podspec-json-format branch from 241ef6b to 0b48249 Compare February 14, 2025 17:06
@github-actions GitHub Actions
Copy link

This PR will not create a new release 🚀

@erayaydin erayaydin marked this pull request as ready for review February 14, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilfa ilfa ilfa approved these changes

@necipallef necipallef necipallef approved these changes

@TheUnderScorer TheUnderScorer TheUnderScorer approved these changes

@Orkuncakilkaya Orkuncakilkaya Awaiting requested review from Orkuncakilkaya

@JuroUhlar JuroUhlar Awaiting requested review from JuroUhlar

Assignees

@erayaydin erayaydin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erayaydin @ilfa @necipallef @TheUnderScorer