Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize Fingerprint Native SDK Version #148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erayaydin
Copy link

This PR refactors the Android build setup by externalizing the Fingerprint Native SDK version and applying an external fingerprint.gradle Gradle script to keep changes in a single file.

Changes:

  • Moved the Fingerprint Native SDK version to a variable fingerprint_native_sdk_version for easier access.
  • Applied an external Gradle script (fingerprint.gradle) to centralize Fingerprint SDK changes.
  • Created printFingerprintNativeSDKVersion gradle task to output the current Fingerprint Native SDK version identifier.

Moved Fingerprint SDK version identifier to a separate variable
`fingerprint_native_sdk_version``for easier access. Applied
external `fingerprint.gradle` script to keep changes in single
file. Created `printFingerprintNativeSDKVersion` gradle task
to output current version identifier.

Related-Task: INTER-1119
@erayaydin erayaydin added the enhancement New feature or request label Feb 14, 2025
@erayaydin erayaydin self-assigned this Feb 14, 2025
Copy link

This PR will not create a new release 🚀

Copy link

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 47.14% 66/140
🔴 Branches 38.78% 19/49
🔴 Functions 43.9% 18/41
🔴 Lines 45.59% 62/136

Test suite run success

21 tests passing in 3 suites.

Report generated by 🧪jest coverage report action from 8e37341

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🔴 All files 47.14 38.77 43.9 45.58
🟡  FingerprintJsProAgent.ts 76.92 76.47 100 76.92 39,59-62,95,103
🟡  FingerprintJsProContext.ts 75 100 0 75 5
🟢  FingerprintJsProProvider.tsx 93.33 50 100 93.33 44
🔴  errors.ts 15.38 10.71 15.38 15.38 8-33,56-249,272-285,332-336,343-379,383
🔴  index.ts 0 0 0 0
🔴  types.ts 0 0 0 0
🟢  useVisitorData.ts 100 100 100 100

@erayaydin erayaydin marked this pull request as ready for review February 14, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants