Return the complete category image path #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprankhub
reviewed
Dec 30, 2021
| @@ -1298,7 +1298,7 @@ protected function uploadMediaFiles($fileName) | |||
| { | |||
| try { | |||
| $res = $this->getUploader()->move($fileName); | |||
| return $res['file']; | |||
| return '/media/catalog/category' . $res['file']; | |||
There was a problem hiding this comment.
It is rather strange that this is needed as this should be handled already:
FireGento_FastSimpleImport2/Model/Import/Category.php
Lines 1331 to 1333 in 1f791a4
There was a problem hiding this comment.
It's not on my side, could you try?
This is what I have:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a category image is imported, it's saved without the
media/catalog/categorypath.For instance, if I import a
main.jpgimage, it will be saved as/m/a/main.jpg, causing a 404 when the image is displayed.I'm not sure if it's the cleanest way to do it tho.