Added optional delimiter field, extended documentation and renamed plugin, as it is not only about the hostname anymore #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tormen
commented
Oct 3, 2017
Tormen
commented
- Added optional delimiter field
- Extended documentation (README, options.html, Manifest)
- Renamed plugin, as it is not (only) about the hostname anymore
added 4 commits
October 3, 2017 17:50
* Added optional delimiter field * Added README
flamingspaz
requested changes
Oct 8, 2017
There was a problem hiding this comment.
Hey there, thanks for contributing this!
It looks good to me, except that you're changing the manifest.json file with a new name, which I think may cause it to be rejected as an update to the old addon.
Can you take a look at the comments and make those changes? Other than that, it's looking great.
| protocol = (protocolEnabled ? `${window.location.protocol}//` : ""); | ||
| path = (pathEnabled ? window.location.pathname : ""); | ||
| return ` - ${protocol}${window.location.hostname}${path}`; | ||
| return `${delimiter}${protocol}${window.location.hostname}${path}`; |
There was a problem hiding this comment.
We should keep the spaces around ${delimiter} so users only have to input the characters they want as the delimiter
There was a problem hiding this comment.
Actually, disregard this one. I see the use-cases where delimiters wouldn't need spaces.
| @@ -1,15 +1,15 @@ | |||
| { | |||
|
|
|||
| "manifest_version": 2, | |||
| "name": "Hostname in title", | |||
| "name": "URL (protocol, hostname, path) in title", | |||
There was a problem hiding this comment.
Please keep this as "hostname in title"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.