[NFC] modifying the testcase by adding Mbackslash and Mnobackslash options together #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivaramaarao
force-pushed
the
shivaram_1440
branch
from
d5abbd6
to
4e6fd09
Compare
bryanpkc
reviewed
Sep 17, 2024
| @@ -8,6 +8,10 @@ | |||
| ! RUN: %flang -c -fno-backslash %s | |||
| ! RUN: not %flang -c -Mnobackslash %s 2>&1 | FileCheck %s | |||
| ! RUN: not %flang -c -fbackslash %s 2>&1 | FileCheck %s | |||
| ! RUN: %flang -c -Mnobackslash -Mbackslash %s | |||
| ! RUN: %flang -c -fbackslash -fno-backslash %s | |||
| ! RUN: not %flang -c -Mnobackslash -Mbackslash -Mnobackslash %s 2>&1 | FileCheck %s | |||
There was a problem hiding this comment.
Is the first instance of -Mnobackslash intentional? It doesn't match the pattern on other lines.
…ash and Mnobackslash options are passed. flang should use the last specified option. e.g Mbaskslash should be used when "-Mnobackslash -Mbackslash <filename>" arguments are specified.
shivaramaarao
force-pushed
the
shivaram_1440
branch
from
4e6fd09
to
c9b1693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flang should use the last specified option when both these options are used. e.g Mbaskslash should be used when "-Mnobackslash -Mbackslash " arguments are specified.