Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched from metadata_url to metadata for end user authentication #26042

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open
Changes from 17 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions it-and-security/default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ org_settings:
end_user_authentication:
entity_id: dogfood-eula.fleetdm.com
idp_name: Google Workspace
metadata_url: $DOGFOOD_MDM_SSO_METADATA_URL
issuer_uri: $DOGFOOD_SSO_ISSUER_URI
metadata: |-
$DOGFOOD_SSO_METADATA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allenhouchins based on my testing for #26135 I would experiment with moving this two spaces forward or two spaces back, i.e.

      metadata: |-
      $DOGFOOD_SSO_METADATA

or

      metadata: |-
          $DOGFOOD_SSO_METADATA

and see if either of those works.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgress454 No change in behavior.
Two spaces forward: 2927aa3
Two spaces backward: c1bc859

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for trying

metadata_url: ""
apple_business_manager:
- organization_name: Fleet Device Management Inc.
macos_team: "💻 Workstations"
Expand Down Expand Up @@ -56,7 +59,7 @@ org_settings:
enable_sso_idp_login: false
entity_id: dogfood.fleetdm.com
idp_image_url: ""
idp_name: Google
idp_name: Google Workspace
issuer_uri: $DOGFOOD_SSO_ISSUER_URI
metadata: |-
$DOGFOOD_SSO_METADATA
Expand Down
Loading