Add missing fmpz_mod_mpoly_compose_ functions #2068
Draft
+883
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the documented, but unimplemented `fmpz_mod_mpoly_compose_fmpz_mod_mpoly_gen` function. Adds `fmpz_mod_mpoly_compose_horner` function.
Jake-Moss
commented
Sep 16, 2024
Comment on lines
+56
to
+67
| /* fmpz_mod_mpoly_set_str_pretty(C + 0, "x1", NULL, ctxAC); */ | ||
| /* fmpz_mod_mpoly_set_str_pretty(C + 1, "2*x2", NULL, ctxAC); */ | ||
| /* fmpz_mod_mpoly_set_str_pretty(C + 2, "1", NULL, ctxAC); */ | ||
| /* if (fmpz_mod_mpoly_compose_fmpz_mod_mpoly(A, B, Cp, ctxB, ctxAC) || */ | ||
| /* fmpz_mod_mpoly_compose_fmpz_mod_mpoly_horner(A1, B, Cp, ctxB, ctxAC) || */ | ||
| /* fmpz_mod_mpoly_compose_fmpz_mod_mpoly_geobucket(A2, B, Cp, ctxB, ctxAC)) */ | ||
| /* { */ | ||
| /* printf("FAIL\n"); */ | ||
| /* flint_printf("Check non-example 2\n", i); */ | ||
| /* fflush(stdout); */ | ||
| /* flint_abort(); */ | ||
| /* } */ |
There was a problem hiding this comment.
Here is the test case in question.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some work on python-flint I noticed that the
fmpz_mod_mpoly_compose_fmpz_mod_mpoly_gensfunction was documented, but unimplemented. I've looked through the git history appears it was never implemented, only added as a doc string.This PR adds that function and the other missing
fmpz_mod_mpoly_compose_hornerfunction. As well as a set of test cases for the compose functions.I've retained the copyright headers from the
fmpz_mpolyandnmod_mpolyrelated files as these new ones are largely a copy-paste + search-replace + minor edits.One test cases is commented out as I'm not sure why it isn't passing. I believe it's near identical to it's counter parts. Something is up with it. I'll marked the PR as draft until I can take a deeper look.
I'm not sure why these functions were not implemented previously. Perhaps just an oversight.