workflows: add sanity check for toolchains w/ CXX support #9277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fluent#7741 e.g. fluent-bit is a c-only library, so allow compilation without cxx Upstream: confluentinc/librdkafka#4366 Signed-off-by: Thomas Devoogdt <[email protected]>
Fluent-bit is c only, so no need to compile cxx. This fixes also a compile error in buildroot. Signed-off-by: Thomas Devoogdt <[email protected]>
ThomasDevoogdt
requested review from
niedbalski,
patrick-stephens,
celalettin1286,
fujimotos,
edsiper,
leonardo-albertovich and
koleini
as code owners
ThomasDevoogdt
force-pushed
the
feature/enforce-no-cxx-support
branch
from
06b1ed2
to
7cb18ea
Compare
ThomasDevoogdt
changed the title
ThomasDevoogdt
force-pushed
the
feature/enforce-no-cxx-support
branch
2 times, most recently
from
df21434
to
ddf2522
Compare
Upstream: nghttp2/nghttp2@d9d2661 Signed-off-by: Thomas Devoogdt <[email protected]>
Signed-off-by: Thomas Devoogdt <[email protected]>
Fluent-bit is written in C, so don't require CXX, also not from the libs. Signed-off-by: Thomas Devoogdt <[email protected]>
ThomasDevoogdt
force-pushed
the
feature/enforce-no-cxx-support
branch
from
ddf2522
to
a3c1402
Compare
|
Hi, we don't want to modify the vendored libraries by ourselves. |
Understand that, see my other PR/ remark #7765 (comment). There is an upstream PR: confluentinc/librdkafka#4366, but no reply in over a year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fluent-bit is written in C. There is no reason to have a CXX compiler. (Except for some libs which are all individually optional.) So add a check that enforces a C-only toolchain. E.g. useful for buildroot which does support platforms with only a C compiler.
This PR is WIP, I otherwise don't have a way to test the GitHub actions.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.