file_sqldb : Removed db shared check through shared member valriable #9383
+0
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While initializing the db handlers , there is check db_temp->shared == TRUE .
However the check does not see if the db name is same for the stanzas or not , It just checks the 1st DB where shared is true and skips the rest check .
Let's consider 2 different configurations .
[INPUT]
name tail
path /mnt/a.log
db /mnt/a.db
storage.type filesystem
[INPUT]
name tail
path /mnt/b.log
db /mnt/a.db
storage.type filesystem
[INPUT]
name tail
path /mnt/c.log
db /mnt/c.db
storage.type filesystem
Expectation
2 databases should be created in sqlite3 , but 1 database is created -- a
[INPUT]
name tail
path /mnt/a.log
db /mnt/a.db
storage.type filesystem
[INPUT]
name tail
path /mnt/b.log
db /mnt/b.db
storage.type filesystem
[INPUT]
name tail
path /mnt/c.log
db /mnt/a.db
storage.type filesystem
Expectation
2 databases should be created in sqlite3 and 2 database is created -- a,b
This behavior is inconsistent due to the shared check .
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.