Skip to content

Commit

Permalink
fix(homepage): passed the homepage through to the repo settings
Browse files Browse the repository at this point in the history
previously, it was looked up from the wrong location on the return from the language scaffolder

fixes #58
  • Loading branch information
travi committed Jun 12, 2018
1 parent 0ca529b commit 4680cc5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/scaffolder.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export async function scaffold(options) {
projectRoot,
projectType,
description,
homepage: language && language.homepage
homepage: language && language.projectDetails.homepage
}),
answers[questionNames.GIT_REPO] && scaffoldGit({projectRoot, ...language && {ignore: language.vcsIgnore}}),
copyFile(resolve(__dirname, '..', 'templates', 'editorconfig.txt'), `${projectRoot}/.editorconfig`)
Expand Down
6 changes: 3 additions & 3 deletions test/unit/scaffolder-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ suite('project scaffolder', () => {
.withArgs({projectRoot: projectPath, license, copyright, vcs})
.resolves({badge: licenseBadge});
vcsHostScaffolder.default.withArgs({host: repoHost, projectRoot: projectPath, projectType, description}).resolves();
languageScaffolder.scaffold.resolves({badges: {status: {ci: ciBadge}}, vcsIgnore});
languageScaffolder.scaffold.resolves({badges: {status: {ci: ciBadge}}, vcsIgnore, projectDetails: {}});

return scaffold(options).then(() => {
assert.calledWith(gitScaffolder.default, {projectRoot: projectPath, ignore: vcsIgnore});
Expand Down Expand Up @@ -215,7 +215,7 @@ suite('project scaffolder', () => {
status: languageStatusBadges
},
verificationCommand,
homepage
projectDetails: {homepage}
});
vcsHostScaffolder.default.resolves();

Expand Down Expand Up @@ -257,7 +257,7 @@ suite('project scaffolder', () => {
test('that running a verification command is not attempted when not provided', () => {
optionsValidator.validate.withArgs(options).returns({});
prompts.prompt.resolves({});
languageScaffolder.scaffold.resolves({badges: {}});
languageScaffolder.scaffold.resolves({badges: {}, projectDetails: {}});

return scaffold(options).then(() => assert.notCalled(exec.default));
});
Expand Down

0 comments on commit 4680cc5

Please sign in to comment.