Upgrade Django 3.2 #34
Conversation
|
Hi @hthungdot, I noticed that you are new to contributions. That's a great start! However, I would like to offer some advice. Before submitting a pull request, please claim the issue and refer to it in the pull request's description. Additionally, provide some information on what exactly you have done. This will make it easier for the reviewer to assess. Once again, best of luck with your upcoming contributions. Cheers! |
|
|
||
| try: | ||
| res[k] = f['evaluate'](instance, instance.order, ev) | ||
| except: |
There was a problem hiding this comment.
Please use more specfic error class with except. Don't use bare except or except Exception.
| etag = None | ||
| try: | ||
| has_image = etag = f['etag'](instance, instance.order, ev) | ||
| except: |
|
how did you install django 3.2 to test this? the requirements files have not been updated to reflect the new versions needed. see src/requirements/*.txt |
|
@eMBee This pull request is not finished, but I committed what I have done so far. I hope someone else can finish it. |
ok, no worries. could you please outline which steps you took to get this far? i think it would help me and others to continue the work if we know how you created the current patch. |
| from django.views.decorators.csrf import csrf_exempt | ||
|
|
||
| import pretix.presale.views.cart | ||
| import pretix.presale.views.checkout | ||
| import pretix.presale.views.customer |
There was a problem hiding this comment.
This "customer" module doesn't exist.
Don't know how you come up with the name of the views imported from it.
No description provided.