Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize menu items #458

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Standardize menu items #458

merged 3 commits into from
Nov 26, 2024

Conversation

lcduong
Copy link
Contributor

@lcduong lcduong commented Nov 25, 2024

This PR resolves #453
Update label for items

Rename Dashboard to "Tickets dashboard" a) in page heading, b) in the left sidebar
image

On the events page https://app-test.eventyay.com/tickets/control/events/ change "Events" to "My events"
In the left sidebar change "My Orders" to "My orders"

image

On the top right drop-down change "My Orders" to "My orders" and "My events" to "My events"
image

Change "Go to shop" to "View event"
image

On eventyay common https://app-test.eventyay.com/tickets/common/ change "Events" to "My events"
image

Summary by Sourcery

Enhancements:

  • Standardize menu item labels across the application for consistency.

Copy link

sourcery-ai bot commented Nov 25, 2024

Reviewer's Guide by Sourcery

This PR standardizes menu item labels across the application by updating text in various UI components to ensure consistent naming conventions. The changes primarily involve renaming navigation items, headings, and button labels.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated navigation menu labels for consistency
  • Renamed 'Dashboard' to 'Tickets dashboard' in both page heading and sidebar
  • Changed 'My Orders' to 'My orders' in the sidebar
  • Changed 'Events' to 'My events' in navigation
src/pretix/control/navigation.py
src/pretix/control/templates/pretixcontrol/dashboard.html
src/pretix/eventyay_common/context.py
Updated user dropdown menu labels
  • Changed 'My Orders' to 'My orders'
  • Changed 'My Events' to 'My events'
src/pretix/static/pretixcontrol/js/ui/popover.js
Modified event view button text
  • Changed 'Go to shop' to 'View event' in all instances
src/pretix/control/templates/pretixcontrol/base.html
Updated events page heading
  • Changed 'Events' to 'My events' in the page title
src/pretix/control/templates/pretixcontrol/events/index.html
Updated translation files
  • Modified language files to reflect the new text changes
src/pretix/locale/*/LC_MESSAGES/django.po

Assessment against linked issues

Issue Objective Addressed Explanation
#453 Rename 'Dashboard' to 'Tickets dashboard' in page heading and left sidebar
#453 Change various menu items to standardized casing ('My events', 'My orders', 'View event')
#453 Update 'Events' to 'My events' in eventyay common page

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@lcduong lcduong marked this pull request as ready for review November 25, 2024 10:03
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lcduong - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mariobehling mariobehling merged commit 207dc8b into fossasia:development Nov 26, 2024
5 of 7 checks passed
HungNgien pushed a commit to HungNgien/eventyay-tickets that referenced this pull request Dec 4, 2024
* Standardize menu items

* update label for my event in common

* remove duplicated translate messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize menu items
2 participants