-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add paypal installation as private repo #467
Conversation
Reviewer's Guide by SourceryThis PR implements changes to replace the built-in PayPal plugin with a private eventyay-paypal dependency. The implementation involves modifying the dependency management system to handle GitHub tokens for private repository access and removing the existing PayPal plugin code. Class diagram for dependency management changesclassDiagram
class DependencyManager {
+loadPyproject()
+writePyproject()
+updateDependencies(github_token)
}
class Pyproject {
+dependencies: List<String>
}
DependencyManager --> Pyproject
note for DependencyManager "Handles loading, updating, and writing pyproject.toml"
note for Pyproject "Represents the pyproject.toml structure"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @HungNgien - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please remove the GitHub token placeholder from pyproject.toml to avoid potential security issues. Token handling should be done entirely through environment variables or configuration.
- The PR would benefit from more detailed documentation explaining the rationale for replacing the built-in PayPal plugin with the private repository version, along with any necessary migration steps for existing users.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
* Standardize menu items * update label for my event in common * remove duplicated translate messages
Updates the requirements on [stripe](https://github.com/stripe/stripe-python) to permit the latest version. - [Release notes](https://github.com/stripe/stripe-python/releases) - [Changelog](https://github.com/stripe/stripe-python/blob/master/CHANGELOG.md) - [Commits](stripe/stripe-python@v5.4.0b1...v11.3.0) --- updated-dependencies: - dependency-name: stripe dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
04afdb7
to
821e0f0
Compare
Summary by Sourcery
Add support for installing the eventyay-paypal dependency as a private repository using a GitHub token, and remove the pretix.plugins.paypal plugin from the settings.
New Features:
Enhancements: