-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies #489
Upgrade dependencies #489
Conversation
Reviewer's Guide by SourceryThis pull request upgrades the Class diagram showing updated Sentry integration changesclassDiagram
class EventScrubber {
+denylist: List
+recursive: bool
+scrub(event)
}
class SentryConfig {
+traces_sample_token: str
+traces_sample_rate: float
+traces_sampler(context)
}
class ImageProcessing {
+create_thumbnail(sourcename, size)
+resize(scale, Resampling.LANCZOS)
}
note for EventScrubber "New built-in scrubber
replaces custom implementation"
note for ImageProcessing "Updated to use Resampling.LANCZOS"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @HungNgien - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sentry-sdk from 1.15.* -> 2.19.*
Pillow from 10.4.* -> 11.0.*
Summary by Sourcery
Update Pillow to 11.0.* and Sentry to 2.19.*.