Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #489

Merged
merged 3 commits into from
Jan 1, 2025
Merged

Conversation

HungNgien
Copy link
Collaborator

@HungNgien HungNgien commented Dec 30, 2024

Sentry-sdk from 1.15.* -> 2.19.*
Pillow from 10.4.* -> 11.0.*

Summary by Sourcery

Update Pillow to 11.0.* and Sentry to 2.19.*.

Copy link

sourcery-ai bot commented Dec 30, 2024

Reviewer's Guide by Sourcery

This pull request upgrades the sentry-sdk and Pillow libraries. It updates the Sentry integration to be compatible with version 2.19.* and removes custom data scrubbing logic in favor of the built-in scrubber. It also updates the Pillow library to 11.0.*, changing the LANCZOS resampling filter to Resampling.LANCZOS.

Class diagram showing updated Sentry integration changes

classDiagram
    class EventScrubber {
        +denylist: List
        +recursive: bool
        +scrub(event)
    }

    class SentryConfig {
        +traces_sample_token: str
        +traces_sample_rate: float
        +traces_sampler(context)
    }

    class ImageProcessing {
        +create_thumbnail(sourcename, size)
        +resize(scale, Resampling.LANCZOS)
    }

    note for EventScrubber "New built-in scrubber
replaces custom implementation"
    note for ImageProcessing "Updated to use Resampling.LANCZOS"
Loading

File-Level Changes

Change Details Files
Upgrade sentry-sdk to 2.19.*
  • Updated the Sentry integration to handle ASGI requests.
  • Removed custom data scrubbing logic.
  • Added a traces sampler to control the sampling rate based on a token in the query string.
  • Added a denylist for sensitive data.
  • Updated the sentry-sdk dependency in pyproject.toml.
src/pretix/sentry.py
src/pretix/settings.py
pyproject.toml
Upgrade Pillow to 11.0.*
  • Updated the LANCZOS resampling filter to Resampling.LANCZOS.
  • Updated the Pillow dependency in pyproject.toml.
src/pretix/helpers/thumb.py
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@HungNgien HungNgien marked this pull request as ready for review December 30, 2024 02:22
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @HungNgien - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mariobehling mariobehling merged commit a247d00 into fossasia:development Jan 1, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants