-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix documentation for Wikimedia SSO #511
Merged
mariobehling
merged 3 commits into
fossasia:development
from
HungNgien:update_sso_document
Jan 17, 2025
Merged
Fix documentation for Wikimedia SSO #511
mariobehling
merged 3 commits into
fossasia:development
from
HungNgien:update_sso_document
Jan 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis PR updates the documentation for setting up Wikimedia SSO and fixes the callback URL for Google, GitHub, and Wikimedia providers. It also updates the labels for client ID and secret in the admin settings. Sequence diagram for SSO authentication flowsequenceDiagram
participant User as User
participant App as Eventyay App
participant Auth as OAuth Provider
User->>App: Click Login with SSO
App->>Auth: Redirect to OAuth provider
Auth->>User: Show login page
User->>Auth: Enter credentials
Auth->>App: Redirect to callback URL with auth code
Note right of App: Updated callback URLs:
Note right of App: app.eventyay.com/tickets/accounts/
Note right of App: {provider}/login/callback/
App->>Auth: Exchange code for tokens
Auth->>App: Return tokens
App->>User: Complete login
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
mariobehling
requested changes
Jan 16, 2025
src/pretix/plugins/socialauth/templates/socialauth/social_setup.html
Outdated
Show resolved
Hide resolved
src/pretix/plugins/socialauth/templates/socialauth/social_setup.html
Outdated
Show resolved
Hide resolved
This feature should work independently from the domain where it is deployed. |
mariobehling
approved these changes
Jan 17, 2025
hongquan
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #500
Summary by Sourcery
Update the documentation for setting up Wikimedia single sign-on (SSO) and correct the callback URL for Google, GitHub, and Wikimedia providers. Standardize the terminology used for client ID and secret across different providers in the settings.
Enhancements:
Documentation: