Fix: document ignored_warnings_from setting
#1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
changed the title
ignored_file_paths setting
zerosnacks
changed the title
ignored_file_paths settingignored_warnings_from setting
zerosnacks
reviewed
Sep 17, 2024
There was a problem hiding this comment.
Thanks @mabsattar
Looks like this was actually already added in https://github.com/foundry-rs/book/pull/1115/files by you which is sufficient - the ticket was not closed correctly.
Don't think the additional comments are necessary but merging in the typo fix
Thanks!
|
Oh yea remember it now.. great that it's closing now, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
documented the 'ignored_warning_from' section in references of solidity-compiler doc
Closes: #1114