Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced by-name deployment and
declare-deploy
command #2331base: master
Are you sure you want to change the base?
Introduced by-name deployment and
declare-deploy
command #2331Changes from 32 commits
eecc2e2
c4dbf57
69cf938
c449de5
1f74c9c
b87ef03
436dd28
48ab4a9
c84afe1
f691a22
40b8ad7
d6b13d3
873f524
9739534
41880aa
ae24960
c29673b
9af83f9
8f9502a
6350ac6
67b2b96
79f23e9
fa5052f
9a60f27
c272f71
1d0341e
15d26df
7578221
f085c3e
7b77cd3
85f478e
b11b1bc
12bd252
a339919
9404f3b
e4b99df
e510eaa
61e8f2a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So now we will explicitly fail if user tries to deploy contract that wasn't declared? What was the previous behavior. This might be worth including in a changelog if this behavior changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we explicitly document that
declare-deploy
behave exactly as deploy if the contract has been already declared?