Fix EEPROM checksum to not be lastchar or lastchar+1 #266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per gnea#158 the logical OR in the code below discards most of the checksum information, resulting in the final chekcsum being either the last character, or the last character +1.
grbl-Mega-5X/grbl/eeprom.c
Lines 130 to 149 in 7a293a9
This fix brings the checksum in-line with grblHAL's implementation: https://github.com/grblHAL/core/blob/3a84b58d301f04279268b4ef1045fd6bc0961be5/nuts_bolts.c#L267-L278
See also the discussion at grbl#1249