jondavidjohn#56 - DinersClub validation

frappacchio · Dec 9, 2018 · db79ffc · db79ffc
1 parent 936d261
commit db79ffc
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/CARDRULES.md b/CARDRULES.md
@@ -12,7 +12,7 @@ The following list contains Issuer Identification Number (IIN) patterns and leng
 
 ### Diners Club <img src="https://user-images.githubusercontent.com/6437556/45498174-8400b500-b747-11e8-9afd-85ea2441a9be.png" width="30" height="20">
 
-**IIN Pattern:** 36, 38, 30[0-5] <sup>[3]</sup>
+**IIN Pattern:** 36, 38, 30[0-5]<sup>[3]</sup>, 309<sup>[13]</sup>
 
 **Length:** 14 <sup>[3]</sup>
 
@@ -99,6 +99,7 @@ The following list contains Issuer Identification Number (IIN) patterns and leng
 [10]: https://github.com/Adyen/adyen-magento/issues/236
 [11]: https://tech.dibspayment.com/D2/Toolbox/Test_information/Cards
 [12]: http://blog.unibulmerchantservices.com/12-signs-of-a-valid-mastercard-card/
+[13]: https://en.wikipedia.org/wiki/Payment_card_number#Issuer_identification_number_(IIN)
 
 
 
diff --git a/src/payform.coffee b/src/payform.coffee
@@ -147,7 +147,7 @@
     }
     {
       type: 'dinersclub'
-      pattern: /^(36|38|30[0-5])/
+      pattern: /^(36|38|30[0-59])/
       format: /(\d{1,4})(\d{1,6})?(\d{1,4})?/
       length: [14]
       cvcLength: [3]

diff --git a/test/validateCardNumber_spec.coffee b/test/validateCardNumber_spec.coffee
@@ -65,6 +65,7 @@ describe 'payform', ->
       assert(payform.validateCardNumber('38520000023237'), 'dinersclub')
       assert(payform.validateCardNumber('36700102000000'), 'dinersclub')
       assert(payform.validateCardNumber('36148900647913'), 'dinersclub')
+      assert(payform.validateCardNumber('30932281347102'), 'dinersclub')
 
       assert(payform.validateCardNumber('6011111111111117'), 'discover')
       assert(payform.validateCardNumber('6011000990139424'), 'discover')