Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PMAX indicator #160

Merged
merged 4 commits into from
Feb 22, 2021
Merged

Added PMAX indicator #160

merged 4 commits into from
Feb 22, 2021

Conversation

pfakanator
Copy link
Contributor

Added PMAX from @tarantula3535 as discussed in #148

pfakanator and others added 4 commits February 20, 2021 12:38
@pfakanator
Added PMAX indicator
1817d4e 
Added PMAX from @tarantula3535 as discussed in freqtrade#148
@pfakanator
Remove Indent
6c1430d 
didn't flake8
@pfakanator
Formatting
d3fd7dd 
sorry, first PR ever, I'm learning.
@xmatthias
Fix some styling
37d6d35
xmatthias
xmatthias reviewed Feb 22, 2021
View reviewed changes
Copy link
Member

@xmatthias xmatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot! 👍

I do trust both of you that the indicator calculates correctly (According to the pinescript code).

@xmatthias xmatthias merged commit a99171d into freqtrade:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmatthias xmatthias xmatthias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pfakanator @xmatthias