Add check for 0x in hex string
#172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a41c890 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@aulneau anything left to address here? |
sjc5
reviewed
Mar 19, 2023
Comment on lines
10
to
16
| export function hexToBytes(hex: string): Uint8Array { | ||
| if (typeof hex !== 'string') | ||
| throw new TypeError('hexToBytes: expected string, got ' + typeof hex); | ||
| if (hex.startsWith('0x')) hex = cleanHex(hex); | ||
| if (hex.length % 2) | ||
| throw new Error(`hexToBytes: received invalid unpadded hex, got: ${hex.length}`); | ||
| const array = new Uint8Array(hex.length / 2); |
There was a problem hiding this comment.
@whoabuddy Perhaps something along these lines would be a little closer to the micro-stacks coding style:
Suggested change
| export function hexToBytes(hex: string): Uint8Array { | |
| if (typeof hex !== 'string') | |
| throw new TypeError('hexToBytes: expected string, got ' + typeof hex); | |
| if (hex.startsWith('0x')) hex = cleanHex(hex); | |
| if (hex.length % 2) | |
| throw new Error(`hexToBytes: received invalid unpadded hex, got: ${hex.length}`); | |
| const array = new Uint8Array(hex.length / 2); | |
| export function hexToBytes(hex: string): Uint8Array { | |
| if (typeof hex !== 'string') | |
| throw new TypeError('hexToBytes: expected string, got ' + typeof hex); | |
| const cleanedHex = cleanHex(hex); // already tolerant of both prefixed and non-prefixed args | |
| if (cleanedHex.length % 2) | |
| throw new Error(`hexToBytes: received invalid unpadded hex, got: ${cleanedHex.length}`); | |
| const array = new Uint8Array(cleanedHex.length / 2); |
And of course use cleanedHex in remainder of fn as well. Just my two cents.
|
@whoabuddy can you add a changesets please? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
hexToBytes()to remove the0xin a string if detected, which fixes #171.Originally I just used
if (hex.startsWith('0x')) hex = hex.slice(2);but then found thecleanHex()function at the bottom and used that instead.Is this the only spot that needs to be updated?