Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -Wall Compilation #1276 #1277

Closed
wants to merge 6 commits into from
Closed

Conversation

christophe-lunarg
Copy link

A PR to run C.I. on #1276 because I don't know how to do it differently...

In #1263 the compilation fails because of various compiler warnings that are treated as errors.
This PR eliminates (all) warnings when compiling with clang-15 and gcc-11.4.

Two notable changes that could work as standalone PR's:

In packing.inl the pointer to the data of vector types that is passed into memcpy calls is retrieved using the value_ptr() method, which is also semantically more precise.
In type_ptr.inl there was a declaration of value_ptr() for vec<1, T, Q> types missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants