Python 3.13 compatibility, and upgrade to Cython 3 #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Python 3.7 should also be removed from CI since it's EOL and causing CI failures. I'll also do that in this PR. |
kroq-gar78
force-pushed
the
py3.13_fixes
branch
2 times, most recently
from
4d984bc to
5b725a0
Compare
kroq-gar78
force-pushed
the
py3.13_fixes
branch
from
5b725a0 to
abe5997
Compare
|
Wow nice, great job! For the codespell failure, could you add Line 11 in ff58a7e (I'm not sure why it's failing now and not before, maybe lins was added recently to the codespell database.) |
|
I just tested it locally on my mac, and it can be installed in python 3.13 and the webgl works 🎉 |
|
Thank you @kroq-gar78, this is great. I will merge and release a new version of pycortex soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It managed to compile on Python 3.12 and 3.13 and run through the tests, but I haven't checked if the webviewer still works yet.
This should fix #563 .