Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition when rendering the UI #285

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 16, 2021

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Summary

Applied the Fix race condition when rendering the UI made in the scene3D to the minimal scene.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde ahcorde requested a review from chapulina September 16, 2021 11:55
@ahcorde ahcorde self-assigned this Sep 16, 2021
@ahcorde ahcorde requested a review from jennuine as a code owner September 16, 2021 11:55
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 16, 2021
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #285 (aeec20b) into main (0221c3a) will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
+ Coverage   65.20%   65.51%   +0.31%     
==========================================
  Files          32       32              
  Lines        4532     4573      +41     
==========================================
+ Hits         2955     2996      +41     
  Misses       1577     1577              
Impacted Files Coverage Δ
src/plugins/minimal_scene/MinimalScene.cc 62.77% <100.00%> (+3.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a2e1af...aeec20b. Read the comment docs.

@chapulina chapulina added beta Targeting beta release of upcoming collection bug Something isn't working labels Sep 16, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chapulina chapulina merged commit 254cc34 into main Sep 17, 2021
@chapulina chapulina deleted the ahcorde/minimal_scene/fix_race_condition branch September 17, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection bug Something isn't working 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants