Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visibility and add documentation #1407

Merged
merged 3 commits into from
Mar 25, 2022
Merged

Fix visibility and add documentation #1407

merged 3 commits into from
Mar 25, 2022

Conversation

mjcarroll
Copy link
Contributor

Addresses visibility bug that breaks the MSVC linker from #1249

@mjcarroll mjcarroll requested a review from azeey March 23, 2022 18:36
@mjcarroll mjcarroll requested a review from chapulina as a code owner March 23, 2022 18:36
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 23, 2022
@chapulina chapulina added the Windows Windows support label Mar 23, 2022
ahcorde
ahcorde approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a comment but you were too fast fixing it!

chapulina
chapulina approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a doc nitpick, and it looks good to me if all platforms compile

@mjcarroll
Reviewer feedback
8305b57 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Copy link
Contributor Author

@osrf-jenkins retest this please

@mjcarroll
Restore dropped macro
69314bf 
Signed-off-by: Michael Carroll <[email protected]>
@codecov
Copy link

codecov bot commented Mar 25, 2022 •
edited
Loading

Codecov Report

Merging #1407 (69314bf) into main (d316196) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1407      +/-   ##
==========================================
- Coverage   62.34%   62.34%   -0.01%     
==========================================
  Files         317      317              
  Lines       24420    24419       -1     
==========================================
- Hits        15225    15224       -1     
  Misses       9195     9195
Impacted Files Coverage Δ
src/EntityComponentManager.cc 89.17% <0.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d316196...69314bf. Read the comment docs.

@mjcarroll
Copy link
Contributor Author

We are building, Windows is compiler errors (mainly related to protobuf, it looks)

@mjcarroll mjcarroll merged commit f6ba375 into main Mar 25, 2022
@mjcarroll mjcarroll deleted the fix_windows branch March 25, 2022 19:42
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@chapulina chapulina chapulina approved these changes

@azeey azeey Awaiting requested review from azeey

Assignees
No one assigned
Labels
🌱 garden Ignition Garden Windows Windows support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjcarroll @azeey @ahcorde @chapulina