Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Hydrodyanmics parameter names in auv_controls.sdf #1924

Closed
wants to merge 1 commit into from
Closed

Fix Hydrodyanmics parameter names in auv_controls.sdf #1924

wants to merge 1 commit into from

Conversation

laughlinbarker
Copy link

@laughlinbarker laughlinbarker commented Mar 10, 2023 •
edited
Loading

🦟 Bug fix

Fixes #<1923>

Summary

Re-named SDF parameters to match what is expected by Hydrodynamics plugin. Un-patched SDF exhibits unbounded velocity growth as described in #1923

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 10, 2023
@azeey azeey requested a review from arjo129 March 11, 2023 05:17
arjo129
arjo129 reviewed Mar 13, 2023
View reviewed changes
Copy link
Contributor

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed in #1888. The said fix has not yet been forward ported to Garden.

@azeey
Copy link
Contributor

azeey commented Mar 23, 2023

Thanks for the contribution @laughlinbarker, but I'll go ahead and close this as a duplicate of #1888

@azeey azeey closed this Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjo129 arjo129 arjo129 left review comments

@mjcarroll mjcarroll Awaiting requested review from mjcarroll mjcarroll is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laughlinbarker @azeey @arjo129