Deprecate use of added mass via hydrodynamics #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe we should deprecate this option as it has instabilities. The `fluid_added_mass` approach is superior. We should update our tutorials as well. Signed-off-by: Arjo Chakravarty <[email protected]>
caguero
requested changes
Jul 24, 2024
Signed-off-by: Arjo Chakravarty <[email protected]>
caguero
requested changes
Jul 31, 2024
There was a problem hiding this comment.
There are some lines longer than 80 chars. See https://github.com/gazebosim/gz-sim/actions/runs/10098157483/job/27924575770?pr=2493
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
caguero
reviewed
Aug 7, 2024
Signed-off-by: Arjo Chakravarty <[email protected]>
iche033
approved these changes
Aug 8, 2024
|
There's a warning on the Noble CI, but I don't think it's related to this. I'll go ahead and merge. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Addresses #1923
Summary
Sneaking this in before feature freeze for ionic. I believe we should deprecate this option as it has instabilities (see #1923 for more context). The
fluid_added_massapproach is superior. We should update our tutorials as well.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.