Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-misc/cmd-wrapped: new package, add 0.2.0 #186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DMLhope
Copy link
Contributor

@DMLhope DMLhope commented May 8, 2024

No description provided.

@stkw0
Copy link
Contributor

stkw0 commented May 8, 2024

In case you were not aware, you can register as a regular contributor, which allows you to commit directly without the extra step of making a PR and waiting for someone to merge it. See https://wiki.gentoo.org/wiki/Project:GURU/Information_for_Contributors

Copy link
Contributor

@MrRoy MrRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DMLhope,

Like stkw0 explained above, it's easy to get access to commit directly to the dev branch, which gets merged to master every once in a while.
For new packages, we prefer people to obtain commit access directly rather than maintain the package through PRs, due to how frequent PRs may be required to properly maintain the package.

Otherwise the ebuild looks good except one minor thing

# Dependent crate licenses
LICENSE+=" MIT MPL-2.0 Unicode-DFS-2016"
SLOT="0"
KEYWORDS="~amd64"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust packages need to have a QA_FLAGS_IGNORED= variable, otherwise the Gentoo Tinderbox (QA tool) will flag this ebuild as ignoring CFLAGS;

You can add something like
QA_FLAGS_IGNORED="usr/bin/${PN} (if this matches the binary path of course)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants